I’m fixing the warnings from clippy in pijul’s source code and i have a question:
In many places the types LineId, PatchId and Inode are explicitly cloned. These types are Copy types, and calling explicitly clone on it is unnecessary. They are copied by memcopy. But, i don’t know if is preferable for pijul, maybe by readibility reasons, or these types might not be more ‘copy’ types in the future.
Anyway, the question is: should I remove unnecessary calls to Clone for these types?